Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily ......................................................................
Patch Set 1: (1 comment) Can you add a test case that runs a query w/ a mem limit such that the case failed before and passes now? http://gerrit.cloudera.org:8080/#/c/7346/1/be/src/exprs/kudu-partition-expr.cc File be/src/exprs/kudu-partition-expr.cc: Line 87: eval->FreeLocalAllocations(); Can you free the allocations outside of the expr? i.e. in DataStreamSender::Send(). I think we can just do it there on a per batch basis. You'll see we do free the expr allocs for the HASH_PARTITION case, though there it seems to do it every row and I think that may be unnecessarily expensive wrt CPU. -- To view, visit http://gerrit.cloudera.org:8080/7346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
