Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily ......................................................................
Patch Set 1: Thomas, wrt my concern earlier about the hash partitioning case doing the call every row, I checked with Tim and he agreed he didn't think we should do that. So when you're making the change to DataStreamSender can you move the FreeLocalAllocations call for the hash partitioning case down a few lines so it's per-batch and not per-row? -- To view, visit http://gerrit.cloudera.org:8080/7346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
