Michael Ho has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7371/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: Line 1034: t == Type.STRING ? stringValGetValue : null, > One quick question about the code below: As discussed offline, lag() is converted to lead() but it'd be good to double check. http://gerrit.cloudera.org:8080/#/c/7371/1/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: Line 1924: ---- QUERY > Did you have to manually inspect the log output to validate the fix? If so I tried matching against an empty ERRORS session before in some tests. -- To view, visit http://gerrit.cloudera.org:8080/7371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2b69b4ccb9cac076abca19bed6f0b1dd11dfff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
