Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7371/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: Line 1034: t == Type.STRING ? stringValGetValue : null, > As discussed offline, lag() is converted to lead() but it'd be good to doub lag() is *not* converted to lead(), the special handling in the BE is just to deal with a window rewrite that makes lead() easier to execute. http://gerrit.cloudera.org:8080/#/c/7371/1/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: Line 1924: ---- QUERY > I tried matching against an empty ERRORS session before in some tests. Good point, this should have an empty ERRORS section to check there are no errors. I'll add that and for the test case above too. Might be worth thinking about changing the test executor logic to fail if warnings are returned but not declared in an ERRORS section. -- To view, visit http://gerrit.cloudera.org:8080/7371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2b69b4ccb9cac076abca19bed6f0b1dd11dfff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
