Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS1, Line 166: DCHECK_GT(statestore_port, 0); > Configuration errors should usually be propagated back to the user. This wo Fair point - removed the dcheck, and we'll let the bind operation fail (the error msg from that is usually pretty clear). -- To view, visit http://gerrit.cloudera.org:8080/7445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
