Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7445/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS2, Line 67: use_statestore Can you please also remove DECLARE_int32(use_statestore) in impalad-main.cc ? There are few other references to use_statestore in testutil. Not sure if you wanna clean them up too ? http://gerrit.cloudera.org:8080/#/c/7445/2/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: PS2, Line 168: impala_server_ initialized to nullptr ? -- To view, visit http://gerrit.cloudera.org:8080/7445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
