Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 4: Code-Review+1 (2 comments) I think it looks pretty good, please address the few small comments and lets see if Bharath has any more comments. http://gerrit.cloudera.org:8080/#/c/7332/4/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: PS4, Line 127: sleep(2) you tested that this fails without your change? I'm just wondering if 2sec is enough PS4, Line 135: drop database drop database if exists in case it wasn't created yet. same below -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
