Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 4: (3 comments) LGTM, have some small nits. http://gerrit.cloudera.org:8080/#/c/7332/4//COMMIT_MSG Commit Message: PS4, Line 9: Privileges granted to a db/table whos Privileges are granted "to" roles "on" objects. I think this might need a little rephrase. http://gerrit.cloudera.org:8080/#/c/7332/4/fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java File fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java: PS4, Line 76: // Not converting URIs to lower case : // IMPALA-2695: Fix GRANTs on URIs with uppercase letters // (IMPALA-2695) URIs are case sensitive. http://gerrit.cloudera.org:8080/#/c/7332/4/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: PS4, Line 106: grant_rev_db Could you randomize it as discussed in the other thread? Look for usages of "get_random_id()", something like, db_name = "grant_rev_db_" + get_random_id(5) try: create db_name. finally: drop db_name Same with "test_role", thats a pretty common role name and creation fails if it already exists. -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
