Henry Robinson has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7478/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: PS1, Line 119: else { > This is not strictly needed given 'compressor_cleanup' above. Not sure if i I think we should leave it out - decompressor.Close() is guaranteed to be called and leaving this in would call it twice which would be unexpected. Line 119: } else { > Is this needed now? Done http://gerrit.cloudera.org:8080/#/c/7478/1/be/src/util/codec.h File be/src/util/codec.h: PS1, Line 181: out_buffer_ > This isn't NULL-initialized now - not sure if it's necessary but it seems s Done -- To view, visit http://gerrit.cloudera.org:8080/7478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6641f4a08bd2711c4f4515ab29a6e5418cbd5f51 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
