Tim Armstrong has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7226/4/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: Line 327: Status status = FinalizeCurrentPage(); This doesn't seem right - why return a Status if we're going to assume that it's always ok. I actually had a branch where I was going through and fixing all the dropped statuses found by GCC7's [[nodiscard]]. My fixes for propagating the table writer status are here: https://github.com/timarmstrong/incubator-impala/commit/6a9cb5a1d79c52001597b58eb073ff5b70a239f4 I already ran a build with these fixes. Maybe we can just fold that into here. -- To view, visit http://gerrit.cloudera.org:8080/7226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
