Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7479/1/fe/src/main/java/org/apache/impala/catalog/Function.java File fe/src/main/java/org/apache/impala/catalog/Function.java: Line 360: throw new IllegalStateException("Expected function type to be either UDA or UDF."); > This seems like a reasonable thing to do later, but I'm not sure if this wi - Currently we only store scalar/aggregate functions in the table params, basically native UDF/UDAs added by the users. We do that for permanent UDF/UDAs feature (test_permanent_udfs.py) - I agree that we can have corrupted blobs in some edge cases which can potentially hit this else, so a TODO should be good. -- To view, visit http://gerrit.cloudera.org:8080/7479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cfad0213a79d39b77ad9aff701a93f93be4bf7f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
