Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature ......................................................................
Patch Set 1: (1 comment) > (1 comment) > > there were also some other comments that still need to be addressed > - will you be posting an updated review? Yes, I will be posting an updated review addressing those other comments http://gerrit.cloudera.org:8080/#/c/7479/1/fe/src/main/java/org/apache/impala/catalog/Function.java File fe/src/main/java/org/apache/impala/catalog/Function.java: Line 360: throw new IllegalStateException("Expected function type to be either UDA or UDF."); > Thanks for the context. I'm still a bit worried about why this was changed I believe IMPALA-626 is what caused the problem filed in IMPALA-4795 in the first place, you'll notice that in IMPALA-626 in TCatalogObjectFromObjectName only function name, db name and signature are set, when this Tfunction object is sent to catalog.java:getTCatalogObject() which tries to do a Function desc = Function.fromThrift(tfn); and hits this case, finally throwing an exception in function = new Function(FunctionName.fromThrift(fn.getName()), argTypes, Type.fromThrift(fn.getRet_type()), fn.isHas_var_args()); Therefore, this patch will instead fix IMPALA-626 -- To view, visit http://gerrit.cloudera.org:8080/7479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cfad0213a79d39b77ad9aff701a93f93be4bf7f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
