Tim Armstrong has posted comments on this change. Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh File bin/clean.sh: Line 78: FIND_ARGS=("$IMPALA_HOME" -iname '*cmake*' -not -name CMakeLists.txt \ How about we just switch to deleting a whitelist of files instead of trying to blacklist files we don't want to delete? I feel like the current approach is just asking for trouble. E.g. at one point I had a git branch with "cmake" in the name that got blown away by this. I had a quick look and it looks like the generated files that should be deleted are: CMakeCache.txt CTestTestfile.cmake CMakeFiles cmake_install.cmake The directories that these can actually appear in are $IMPALA_HOME/ (not recursive) $IMPALA_HOME/be/ $IMPALA_HOME/fe/ $IMPALA_HOME/common/ $IMPALA_HOME/ext-data-source/ -- To view, visit http://gerrit.cloudera.org:8080/7493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
