Henry Robinson has uploaded a new patch set (#2).

Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
......................................................................

IMPALA-5716: Don't delete cmake_modules/* when enabling distcc

If $IMPALA_HOME ends with a /, the clean_cmake_files function in
distcc_env.sh will emit a find command with a double // at the end for
the cmake_modules directory, and since it contains the substring cmake,
find will match and delete its contents.

Fix is to use a whitelist of locations and filenames to look for, and
delete only those.

Testing: manually ran enable_distcc, observed that my files were still
there.

Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed
---
M bin/clean.sh
M bin/distcc/distcc_env.sh
2 files changed, 12 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/7493/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to