Michael Brown has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: PS1, Line 345: tmpdir Nit: for these private helper methods, prefer a more descriptive name than tmpdir. In the test methods, tmpdir is a fixture that gives you a temporary directory. But in the helper methods, the directory is a local path to put files from HDFS. Maybe outdir or something else? Also, consider updating the docstrings to reflect the need for the extra param. -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia84c78d7ff74cc7fdb3d782060caa5e52d0cd7d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
