David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: PS1, Line 351: tmpdir.strpath Adding on to Michael's comment, rather than passing the whole fixture around, you might even consider just passing tmpdir.strpath initially, since that seems to be the only thing you ultimately need to access in this method. -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia84c78d7ff74cc7fdb3d782060caa5e52d0cd7d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
