Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ......................................................................
Patch Set 8: (2 comments) Just a couple of readability improvements but looks good to go otherwise. http://gerrit.cloudera.org:8080/#/c/7530/8//COMMIT_MSG Commit Message: Line 9: This patch change the behavor when running The paragraph formatting here is a bit hard to read - the lines seem to be wrapped too early. http://gerrit.cloudera.org:8080/#/c/7530/8/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: Line 513: dt_ctx.now = TimestampValue(date(2017, 7, 28), time_duration(16, 14, 24)); Nice :). What do you think about pulling out the value into a local variable or constant near line 475 or up the top of the file so it's easier for readers to find? -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
