Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ......................................................................
Patch Set 9: (1 comment) I followed up with Greg, he said there's no right behavior when you don't specify all 4 years which makes sense, so this behavior is fine. Please address the other comments for now, though. http://gerrit.cloudera.org:8080/#/c/7530/9//COMMIT_MSG Commit Message: PS9, Line 11: same as Hive's > Hive's implementation is at . https://github.com/apache/hive/blob/master/hp Thanks! Please mention this in the commit message and in the code. -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
