Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc File be/src/exec/hdfs-scanner-ir.cc: Line 119: TimestampValue IrStringToTimestamp(const char* s, int len, > It works but since we are returning a C++ class I cannot find this behaviou That makes sense, thanks for explaining. Clang and G++ both support it even though it's not in the standard (we suppress the warning with -Wno-return-type-c-linkage). -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
