Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7556/1//COMMIT_MSG Commit Message: Line 14: > Can you add a short Testing: section here. Done http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc File be/src/exec/hdfs-scanner-ir.cc: Line 119: extern "C" > It looks like the other functions have extern "C" to avoid mangling the fun Done PS1, Line 120: s > Extra space before * Done http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: PS1, Line 246: 16 byte > 16 bytes Done PS1, Line 268: mov > nit: move Done http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/util/string-parser.h File be/src/util/string-parser.h: Line 100: /// Parse a TimestampValue from s. > Nit: add a . on the end for consistency with other comments. Done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
