John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/5//COMMIT_MSG Commit Message: Line 7: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer Not sure what a good commit title would be, this patch has evolved quite a bit. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/benchmarks/network-perf-benchmark.cc File be/src/benchmarks/network-perf-benchmark.cc: Line 206: impala::InitCommonRuntime(argc, argv, false, impala::TestInfo::BE_TEST); I don't think network-perf-benchmark gets used much because it had bit rotted to the point of not working. This change seems to fix it by initializing various things (like InternalAuthProvider and the thread manager). I kept the ParseCommandLineFlags above so the if (argc != -1) code below properly worked. I only did basic local node testing and tested changing the default port. -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
