Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ......................................................................
Patch Set 5: (9 comments) This looks good! Just needs to merge with the recent ThriftServer changes, and consider adding a test where you set the number of concurrent clients and confirm that only that many can connect at once. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/benchmarks/network-perf-benchmark.cc File be/src/benchmarks/network-perf-benchmark.cc: Line 206: impala::InitCommonRuntime(argc, argv, false, impala::TestInfo::BE_TEST); > I don't think network-perf-benchmark gets used much because it had bit rott This is fine - it's sufficient to keep it compiling for now. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/catalog/catalogd-main.cc File be/src/catalog/catalogd-main.cc: Line 91: ThriftServer* server = new ThriftServer("CatalogService", processor, As you'll have seen, IMPALA-5696 switched over to a new ThriftServerBuilder idiom for constructing ThriftServer objects. I think what you'll need to do is remove the threaded() and thread_pool() methods, and just add a max_concurrent_cnxns(int) method. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/rpc/TAcceptQueueServer.h File be/src/rpc/TAcceptQueueServer.h: Line 61: int32_t maxTasks, could you add a TODO to this class to suggest we determine which of these c'tors are actually needed? PS5, Line 114: notifies notified? Line 117: // The maximum number of running tasks allowed at a time. nit: put a new line before this one. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: PS5, Line 409: stringstream key_prefix_ss; : key_prefix_ss << "impala.thrift-server." << name_; while you're here.... use Substitute("impala.thrift-server.$0", name_) ? http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: PS5, Line 176: conncurrent typo PS5, Line 177: until a thread becomes available nit: this makes it sound like the threads are pooled. Suggest 'connections will block until fewer than num_worker_threads_ threads are concurrently active' or something. http://gerrit.cloudera.org:8080/#/c/7061/5/be/src/transport/TSaslServerTransport.cpp File be/src/transport/TSaslServerTransport.cpp: PS5, Line 144: TThreadedServer and : // TThreadPoolServer remove these two? -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
