Tim Armstrong has posted comments on this change. Change subject: IMPALA-2869: Log why codegen is disabled in TextConverter::CodegenWriteSlot() ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7574/2/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS2, Line 326: NULL Switch to nullptr http://gerrit.cloudera.org:8080/#/c/7574/1/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: Line 280: Status("TextConverter::CodegenWriteSlot:codegen'd " ? http://gerrit.cloudera.org:8080/#/c/7574/2/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: Line 76: // %1 = bitcast <{ i32, i8 }>* %tuple_arg to i8* > Why did the IR change? Same question. I'm guessing that the old IR was just stale, in which case - thanks for updating. There's a lot of stale IR in comments since we don't update all the comments in the dependency graph when we change a codegen function (or change the LLVM version). Line 125: if (is_null_string_fn == NULL) { This could be a DCHECK. We shouldn't be missing builtin functions. -- To view, visit http://gerrit.cloudera.org:8080/7574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I355efe2d5566ba6a1b72648763794a79c80c3089 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
