Lars Volker has posted comments on this change. Change subject: IMPALA-2869: Log why codegen is disabled in TextConverter::CodegenWriteSlot() ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7574/2/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: PS2, Line 126: TextConverter::CodegenWriteSlot > oops it should be Impala-2689. I will fix the commit message. Yes, that sounds reasonable. Please add () to the function names to follow our conventions. Line 281: "WriteSlot function failed verification"); > oops it should be Impala-2689. I will fix the commit message in the next pa Following the same convention as elsewhere in the code makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/7574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I355efe2d5566ba6a1b72648763794a79c80c3089 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
