Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface ......................................................................
Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/exec/exchange-node.h File be/src/exec/exchange-node.h: PS6, Line 39: > nit: long line Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/data-stream-mgr-base.h File be/src/runtime/data-stream-mgr-base.h: PS6, Line 36: one each for Thrfit and KRPC > for Thrift and KRPC respectively. Done PS6, Line 36: implementations > typo. Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/data-stream-recvr-base.h File be/src/runtime/data-stream-recvr-base.h: PS6, Line 33: one each for Thrfit and KRPC > for Thrift and KRPC respectively. Done PS6, Line 33: implementations > implementations Done PS6, Line 47: > extra / Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS6, Line 79: Kudu > "Kudu RPC" for clarity. Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: PS6, Line 92: /// Clients of the implementations of DataStreamMgrBase should not use these functions : /// unless they need to access members that are not enforced by the DataStreamMgrBase : /// interface. (This is due to the stream mgrs using different AddData() signatures) : DataStreamMgr* ThriftStreamMgr(); > IMHO, this doesn't seem to provide much value in explaining it here. Can yo I added it because we have a habit of including getters in the header file, and this is an exception. But I too agree that it's not very necessary to explain, so I removed it. Added the extra explanation too. http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/krpc-data-stream-mgr.h File be/src/runtime/krpc-data-stream-mgr.h: PS6, Line 48: > nit: blank space Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: PS6, Line 28: Shouldn't reach here unless startup flag 'use_krpc' " : "is true."; > Can be simplified to "Shouldn't reach here unless startup flag 'use_krpc' i Done http://gerrit.cloudera.org:8080/#/c/7542/6/be/src/runtime/krpc-data-stream-recvr.h File be/src/runtime/krpc-data-stream-recvr.h: PS6, Line 30: KRPC > nit: KRPC Done -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
