Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface ......................................................................
Patch Set 4: (2 comments) I think you need to replace the types of the objects with their base classes where appropriate. For example, ExecEnv::data_stream_mgr_ needs to be a DataStreamMgrBase. http://gerrit.cloudera.org:8080/#/c/7542/4/be/src/runtime/data-stream-mgr.h File be/src/runtime/data-stream-mgr.h: Line 71: ~DataStreamMgr(); not virtual? Line 82: bool is_merging); you'll need to mark the inherited methods as 'override', or clang-tidy will complain. -- To view, visit http://gerrit.cloudera.org:8080/7542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
