Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7596/1/be/src/testutil/rand-util.h File be/src/testutil/rand-util.h: PS1, Line 34: static void SeedRng(const char* env_var, std::mt19937* rng) { : const char* seed_str = getenv(env_var); : int64_t seed; : if (seed_str != nullptr) { : seed = atoi(seed_str); : } else { : seed = time(nullptr); : } : LOG(INFO) << "Random seed (overridable with " << env_var << "): " << seed; : rng->seed(seed); : } Why not change this to use std::random_device instead? See https://github.com/apache/incubator-impala/blob/master/be/src/rpc/authentication.cc#L493-L494 -- To view, visit http://gerrit.cloudera.org:8080/7596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3bec152a58d9ec39413780cb2c431dd8d4fa8 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
