Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test ......................................................................
IMPALA-5031: unsafe random number generation in buffer-pool-test The bug is that ConcurrentRegistration shares one random number generator between all the threads. This isn't safe and UBSAN was unhappy with it. The fix is to create one RNG per thread. We already do that in a different test so the code is factored out into a utility function. Testing: Ran buffer-pool-test under UBSAN Change-Id: I0eb3bec152a58d9ec39413780cb2c431dd8d4fa8 Reviewed-on: http://gerrit.cloudera.org:8080/7596 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/testutil/rand-util.h 2 files changed, 22 insertions(+), 11 deletions(-) Approvals: Impala Public Jenkins: Verified Sailesh Mukil: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eb3bec152a58d9ec39413780cb2c431dd8d4fa8 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
