Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/3/bin/bootstrap_development.sh File bin/bootstrap_development.sh: PS3, Line 21: system : # configurations, so it is best to run this in a fresh install. It also sets up the : # .bashrc of the calling user with some environment variables I know that the impala-setup rep didn't do this, but do you think it would be a good idea to have a warning at the beginning of the script stating that it will clobber the .bashrc and some of the system configuration, with a: "Do you want to continue? [y/n]" prompt below that warning? -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes