Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: Line 154: DCHECK(!all_trackers_[i]->has_limit()); Can we also add DCHECK(!all_tracker_[i]->closed_) here ? Line 210: void Release(int64_t bytes) { Based on the comments in Close(), we may also consider calling DCHECK(!closed_) here because the contract is that the counters are safe to be destroyed after calling Close() and we already DCHECK consumption is 0 in Close(). -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
