Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers ......................................................................
Patch Set 4: (5 comments) Addressed the comments. Was in the middle of a rebase onto the buffer pool changes so that is also included. The rebase removed BufferedBlockMgr but required calling MemTracker::Close() from InitialReservaitons. http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: Line 154: DCHECK(!all_trackers_[i]->has_limit()); > Can we also add DCHECK(!all_tracker_[i]->closed_) here ? Done. Cleaned up some of the iteration over all_trackers_ to use ranged for loops. Line 210: void Release(int64_t bytes) { > Based on the comments in Close(), we may also consider calling DCHECK(!clos Done. Agree with the reasoning. Line 212: if (bytes < 0) Consume(-bytes); :/ I hope we're not calling this with negative values. Seems weird. Line 235: /// TODO: Release brokered memory? Will remove this LLAMA-related TODO http://gerrit.cloudera.org:8080/#/c/7492/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 1: // regarding copyright ownership. The ASF licenses this file > nit: I think you deleted part of the copyright message by accident. Done -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
