John Sherman has posted comments on this change.

Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when 
minidumps are disabled
......................................................................


Patch Set 2:

Should any startup scripts be modified to trap '' SIGUSR1 before launching the 
daemons since there is still technically a race from daemon startup to when the 
mini-dump signal handler is registered? (Though from what I can tell the 
typical usage of the SIGUSR1 mini-dump handler would very likely never 
encounter this race, so maybe not worth fixing?)

-- 
To view, visit http://gerrit.cloudera.org:8080/7631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13d866a2eec832500131954a7f693c33585ea51e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: John Sherman <j...@arcadiadata.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-HasComments: No

Reply via email to