Lars Volker has posted comments on this change. Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled ......................................................................
Patch Set 2: > Should any startup scripts be modified to trap '' SIGUSR1 before > launching the daemons since there is still technically a race from > daemon startup to when the mini-dump signal handler is registered? > (Though from what I can tell the typical usage of the SIGUSR1 > mini-dump handler would very likely never encounter this race, so > maybe not worth fixing?) Yes, that race exists, I don't think it's worth fixing though. Human operators should not hit it. Automated scripts that regularly trigger minidumps sending SIGUSR1 could hit this, but I think we should not encourage those anyways. Let me know if you feel strongly about this. -- To view, visit http://gerrit.cloudera.org:8080/7631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13d866a2eec832500131954a7f693c33585ea51e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
