Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412 Fix scan result with partitions on same file ......................................................................
Patch Set 3: (3 comments) I ended up combining the tests in test_partition_metadata and adding parquet and seq. Reran the tests to confirm that it still failed before the fix. http://gerrit.cloudera.org:8080/#/c/7625/3/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS3, Line 589: c > nit: 4 spaces Done http://gerrit.cloudera.org:8080/#/c/7625/3/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: PS3, Line 86: Imapala > There's still an extra 'a' :) Done PS3, Line 125: > Trailing whitespace. Done -- To view, visit http://gerrit.cloudera.org:8080/7625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie74b305377248045c0d87b911943e1cabb7223e9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
