Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7625/5/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: Line 365: typedef std::unordered_map<PartitionFileKey , HdfsFileDesc*, pair_hash> FileDescMap; > extra space after PartitionFileKey Done http://gerrit.cloudera.org:8080/#/c/7625/5/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: Line 52: def test_multiple_partitions_same_location(self, vector, unique_database): > I think this test could use some cleanup, but I'm ok to accept this patch i I see your point but I don't have the time right now to do this refactoring. I think we should get this in and improve the tests as a separate step (if we think it's important). Line 103: # check if using num_nodes=1 has the same behaviour > # force all scan ranges to be on the same node Done -- To view, visit http://gerrit.cloudera.org:8080/7625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie74b305377248045c0d87b911943e1cabb7223e9 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
