Jim Apple has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt File be/CMakeLists.txt: Line 74: # We need to add additional arguments for GCC 7+. We go down this branch if building > It seems ok - the memory region written is large enough. The function_buffe I'm not thrilled to be turning off this warning. I expect it will be hard to turn it back on. What if we switched boost::function to std::function before this patch? -- To view, visit http://gerrit.cloudera.org:8080/7253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
