Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: Line 748: MakeScopeExitTrigger([&compressor]() { compressor->Close(); }); > I couldn't think of a great alternative. Putting Close() before every retur i prefer goto, but up to you. -- To view, visit http://gerrit.cloudera.org:8080/7253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
