Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7643/2/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 859: * as its root and 'node' is the second phase of the distinct aggregation. update comment Line 864: throws ImpalaException { move into previous line Line 916: Newlines should be used to visually cluster code that logically belongs together. Move this newline right before "DataPartition mergePartition;" - that's where we begin to add the merge agg node (in the preceding code separated by newline we added the phase2AggNode as an intermediate aggregation step) Line 917: phase2AggNode.unsetNeedsFinalize(); You still need to do phase2AggNode.setIsPreagg(ctx_); -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bdada0e328b555900c7b7ff8aabc8eb15ae8fa9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
