Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7643/2/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 859: * as its root. > update comment Done Line 864: // The phase-1 aggregation node is already in the child fragment. > move into previous line Done Line 916: phase2AggNode.setIntermediateTuple(); > Newlines should be used to visually cluster code that logically belongs tog Done Line 917: > You still need to do phase2AggNode.setIsPreagg(ctx_); I think that only works with grouping expr and is at line 922. -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bdada0e328b555900c7b7ff8aabc8eb15ae8fa9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
