Sailesh Mukil has posted comments on this change. Change subject: Impala-992: Rerun past queries from history in shell ......................................................................
Patch Set 2: (3 comments) Could you add some tests for this too? Have a look at $IMPALA_HOME/tests/shell/ for previous examples. http://gerrit.cloudera.org:8080/#/c/7674/2//COMMIT_MSG Commit Message: PS2, Line 7: Impala All caps. http://gerrit.cloudera.org:8080/#/c/7674/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 1080: exists Not your change, but: nit: exist PS2, Line 1102: print_to_stderr("Command index out of range. Valid range: [1, {}]".format(history_length)) long line -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
