Lars Volker has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/7674/4/shell/impala_shell.py File shell/impala_shell.py: Line 1089: """Rerun a command with an command index in history."""\ Unless you're trying to achieve something special, you can just have the string within """ span multiple lines. """Start here Continue here. Then end with three " on a new line. """ See: https://www.python.org/dev/peps/pep-0008/#documentation-strings PS4, Line 1164: character nit: characters PS4, Line 1166: This method transforms '@' into 'rerun' because this is a special : character not defined in cmd.Cmd. I'd probably leave out this sentence since it'll be hard to keep this in sync with the code. It seems sufficient to mention that there's some replacement going on and the curious reader can find all aliases in the code below. -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
