Lars Volker has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG Commit Message: Line 9: This patch adds a new command "rerun" and shortcut "@" to impala-shell. nit: and a shortcut. Line 10: User can rerun a certain query by its index given by history command. nit: users... PS5, Line 12: Negavie typo http://gerrit.cloudera.org:8080/#/c/7674/5/shell/impala_shell.py File shell/impala_shell.py: PS5, Line 1105: format I think this should be aligned with the . under the " according to PEP8. Line 1111: # Remove the semicolon at last. I think this comment now is not needed anymore, the command looks self explanatory enough to me. -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
