Dan Hecht has posted comments on this change. Change subject: IMPALA-5677: limit clean page memory consumption ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7653/1//COMMIT_MSG Commit Message: Line 34: Ran in a loop to flush out any flakiness. do we explicitly test the clean_page_limit={0, buffer_pool_limit} cases? http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: PS1, Line 61: spilled maybe say "unpinned", since "spilled" is more of a operator concept rather than a buffer pool concept. Or just delete the word since clean implies it. http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/runtime/bufferpool/buffer-allocator.cc File be/src/runtime/bufferpool/buffer-allocator.cc: Line 109: int64_t GetCleanPageBytes(); is that still used? PS1, Line 636: one page what does that mean? maybe say, "no other page to evict"? http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/runtime/bufferpool/buffer-allocator.h File be/src/runtime/bufferpool/buffer-allocator.h: PS1, Line 222: the they? PS1, Line 225: remaining I'm not sure it's clear what it means to be "remaining". PS1, Line 228: clean_page_bytes_remaining_ also, this name might be a little confusing. It's nice that it's consistent with system_bytes_remaining_, but I think it's a bit less intuitive since it's not "remaining" in the same sense -- i.e. it's not tracking bytes of clean pages. But maybe just updating the comment will be sufficient. Maybe also saying what the equation is, i.e.: clean_page_bytes_reamining_ + bytes currently used by clean pages = clean_page_bytes_limit_ would help? -- To view, visit http://gerrit.cloudera.org:8080/7653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b687ab4bdddf07d9d6c997ff814aa3976042f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
