Tim Armstrong has posted comments on this change. Change subject: IMPALA-5677: limit clean page memory consumption ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7653/1//COMMIT_MSG Commit Message: Line 34: Ran in a loop to flush out any flakiness. > do we explicitly test the clean_page_limit={0, buffer_pool_limit} cases? I don't have tests for those. We could add a backend test for those cases. There isn't a distinct code path for those cases but I guess it's good to test the edge cases. http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: PS1, Line 61: spilled > maybe say "unpinned", since "spilled" is more of a operator concept rather Done http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/runtime/bufferpool/buffer-allocator.cc File be/src/runtime/bufferpool/buffer-allocator.cc: Line 109: int64_t GetCleanPageBytes(); > is that still used? Done PS1, Line 636: one page > what does that mean? maybe say, "no other page to evict"? Done http://gerrit.cloudera.org:8080/#/c/7653/1/be/src/runtime/bufferpool/buffer-allocator.h File be/src/runtime/bufferpool/buffer-allocator.h: PS1, Line 222: the > they? Done PS1, Line 225: remaining > I'm not sure it's clear what it means to be "remaining". Reworded the comment. PS1, Line 228: clean_page_bytes_remaining_ > also, this name might be a little confusing. It's nice that it's consistent Documented that this is clean_page_bytes_limit_ - bytes of clean pages. I think that makes it less ambiguous. -- To view, visit http://gerrit.cloudera.org:8080/7653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b687ab4bdddf07d9d6c997ff814aa3976042f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
