Henry Robinson has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7673/1/be/src/testutil/in-process-servers.cc File be/src/testutil/in-process-servers.cc: Line 96: RETURN_IF_ERROR(exec_env_->Init()); > I hit a bug in expr-test here where StartServices() starts up the statestor Hm, I didn't see much of a rebase conflict here. I'm really hoping we can get rid of InProcessImpalaServer in short order, however. -- To view, visit http://gerrit.cloudera.org:8080/7673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d55fbe0f4f7a1fd48993da46863b66e521feaae Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
