Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7673/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS2, Line 212: LOG(INFO) << "Starting global services"; > that should probably be updated Done http://gerrit.cloudera.org:8080/#/c/7673/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS2, Line 2035: : Added these logs back. PS2, Line 2021: LOG(INFO) << "Impala HiveServer2 Service listening on " << hs2_port; Spurious log. Line 2046: shutdown_promise_.Get(); We need to join the be_server_, hs2_server_ and beeswax_server_ too here. I'll add it in the next patchset. http://gerrit.cloudera.org:8080/#/c/7673/2/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 1006: boost::shared_ptr<ThriftServer> be_server_; > why do we need shared ptrs for these? can we not have single ownership? I looked through the code and the usage of these pointers and I agree that we can leave them as raw pointers due to single ownership. Done. -- To view, visit http://gerrit.cloudera.org:8080/7673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d55fbe0f4f7a1fd48993da46863b66e521feaae Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
