Dan Hecht has posted comments on this change. Change subject: IMPALA-5641: mem-estimate should never be less than mem-reservation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7703/2/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: Line 72: } it seems like it might be best to keep this class "dumb" (i.e just about syntactic sugar for constructing), and move this logic into ResourceProfile (constructor). After all, wouldn't we want to maintain this invariant regardless of if you use this class or not to create a ResourceProfile? -- To view, visit http://gerrit.cloudera.org:8080/7703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2853300371e31b13d81a763dbafb21709b16c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
