Tim Armstrong has posted comments on this change. Change subject: IMPALA-5641: mem-estimate should never be less than mem-reservation ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7703/4/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: Line 42: * the minimum reservation is used as the memory estimate instead. > This comment is probably better in ResourceProfile itself. There's already a comment in ResourceProfile saying that memEstimateBytes_ >= minReservationBytes_. Do you think we'd be better just deleting this comment? -- To view, visit http://gerrit.cloudera.org:8080/7703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2853300371e31b13d81a763dbafb21709b16c4 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
