Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7640/3/be/src/runtime/disk-io-mgr-handle-cache.h File be/src/runtime/disk-io-mgr-handle-cache.h: PS3, Line 137: : /// in_use is true for a file handle checked out via GetFileHandle() that has not : /// been returned via ReleaseFileHandle(). : bool in_use = false; : Is this necessary? I think the compiler should generate a move constructor for this struct. http://gerrit.cloudera.org:8080/#/c/7640/2/be/src/runtime/disk-io-mgr-handle-cache.inline.h File be/src/runtime/disk-io-mgr-handle-cache.inline.h: PS2, Line 196: FileHandleCache<NUM_PARTITIONS>::FileHandleCachePartition& p > I added detailed comments about the lru list manipulations, but I don't thi wfm, I was thinking out loud but didn't feel strongly about making a big change. Thanks for adding some more comments. -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefe04b3e2e22123ecb8b3e494934c93dfb29682e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
