Tim Armstrong has posted comments on this change. Change subject: IMPALA-5352: Age out unused file handles from the cache ......................................................................
Patch Set 4: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/7640/4/be/src/runtime/disk-io-mgr-handle-cache.h File be/src/runtime/disk-io-mgr-handle-cache.h: Line 94: ~FileHandleCache(); Worth mentioning this is only used for backend tests. PS4, Line 187: true SHUTDOWN_TRUE. http://gerrit.cloudera.org:8080/#/c/7640/4/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: Line 63: def run_fd_caching_test(self, vector, caching_expected, cache_capacity, \ nit: line continuation shouldn't be needed inside parens PS4, Line 113: ( nit: unnecessary parens PS4, Line 150: ): nit: unnecessary parens -- To view, visit http://gerrit.cloudera.org:8080/7640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefe04b3e2e22123ecb8b3e494934c93dfb29682e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
